Update JavaScript with Remy's recommendations
Reported by George Ornbo | July 28th, 2009 @ 10:23 AM | in 1.0.0 Release
- You've got a global in ie6css, hideText, hideLink and
hideParagraph
- I believe (but I've never 100% sure) that you need to change you click handler to include (to ward off any memory leaks):
ie6css = null;
noticeDiv = null;
- I'd just create the div and do the rest with innerHTML - it's
faster and less code.
- ie6Css.setAttribute("href", "") could be written as: ie6Css.removeAttribute("href");
Comments and changes to this ticket
-
George Ornbo July 28th, 2009 @ 10:58 AM
- State changed from “new” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Adds a browser upgrade notice for IE6 users. IE6 is evil and must die.
George Ornbo