Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Update JavaScript with Remy's recommendations

#1
  1. You've got a global in ie6css, hideText, hideLink and hideParagraph
  2. I believe (but I've never 100% sure) that you need to change you click handler to include (to ward off any memory leaks):

ie6css = null;
noticeDiv = null;

  1. I'd just create the div and do the rest with innerHTML - it's faster and less code.
  2. ie6Css.setAttribute("href", "") could be written as: ie6Css.removeAttribute("href");

Reported by George Ornbo · July 28th, 2009 @ 10:23 AM

State: resolved
Milestone: 1.0.0 Release
Assigned to: George Ornbo George Ornbo

Activity

  1. George Ornbo
    George Ornbo
    • State changed from new to resolved

    July 28th, 2009 @ 10:58 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.